Repository navigation
fix(shared): share request context stores across duplicated modules - #15395
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Conversation
Stores lived per module copy, so context opened by one copy was unreadable from another; both now key off the shared registry, proven by a cross-copy interleaving test.
maxmad64bis
force-pushed
the
fix/share-request-context-symbol-for
branch
from
October 2, 2026 22:37
b9210dc to
00ee433
Compare
maxmad64bis
marked this pull request as ready for review
October 3, 2026 01:40
diegosouzapw
merged commit Oct 6, 2026
9e97f04
into
diegosouzapw:release/v3.8.52
149 of 200 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The correlation id and request id stores were still module-level
AsyncLocalStorageinstances, the pattern #14620 moved off for the proxy context: when bundling duplicates one of these modules, the copy that opens the context isn't the one that reads it, and the read falls back to the empty value. Both stores now key offglobalThisviaSymbol.for, so a read from any copy sees the context opened by any other copy; without duplication nothing changes.Related Issues
Validation
npm run lint— ESLint on the touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.52 #15306).Tests Added Or Updated
Coverage Notes
Reviewer Notes
N/A — nothing beyond the Summary changes the review.